DM XMLs - Update 1.4/1.4.1/master to use alchemy 1.5.4 and add namespace XML files. #37527
+8,321
−1,306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alchemy now does namespace parsing. There was also a change to the format of the constraints.
|
PR #37527: Size comparison from 9c8cb33 to 75bca34 Increases above 0.2%:
Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
j-ororke
added a commit
to j-ororke/connectedhomeip
that referenced
this pull request
Feb 19, 2025
- Creating with data provided by Cecille in PR here: project-chip#37527 - Updated test.yaml to include TestSpecParsingNamespace.py to run in CI - Updated matter_testing support module to include new NamespacePathLocation function for Namespace file locations - Updated spec_parsing to include new functions build_xml_namespaces and parse_namespace, as well as XmlNamespaces and XmlTags dataclasses
|
PR #37527: Size comparison from 26a7b1c to 2f7a6a3 Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
ReneJosefsen
approved these changes
Mar 5, 2025
j-ororke
added a commit
to j-ororke/connectedhomeip
that referenced
this pull request
Mar 25, 2025
… code from Cecille's PR #: Namespace parser: - Created new TestSpecParsingNamespace.py unit test to test namespaces - Updated tests.yaml to include TestSpecParsingNamespace.py - Updated test_metadata.yaml to include TestSpecParsingNamespace.py and reasoning - Updated matter_testing support module to include new NamespacePathLocation function for Namespace file locations - Updated spec_parsing to include new functions build_xml_namespaces and parse_namespace, as well as XmlNamespaces and XmlTags dataclasses Datatype parser: - spec_parsing module changes: -- Enhanced XmlDataTypeComponent with fields for docs, types, and constraints -- Added support for detecting optional and nullable fields in XML -- Improved constraint parsing for min/max values and attribute references, basically used for dataTypes -- Improved some error reporting with specific diagnostic messages when parsing dataTypes - TestSpecParsingDataType unit test module: -- Added comprehensive test coverage using Matter 1.4.1 cluster XML files -- Enhanced test output with detailed statistics on XML field usage -- Added error reporting with specific diagnostic messages Additionally: - Removing unneccessary additions in scripts/tests/requirements.txt file - Adding change to scripts/setup/constraints.txt as was needed to build env Updates Cecille's PR project-chip#37527
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing
Data model file formats for clusters and device types are covered by the TestSpecParsing* tests, which are run in CI and also run manually. These are also used in the IDM-10.* tests, which are run in the CI. The new namespace files are not yet used anywhere. Tests will be added when the parsers are added.